Skip to content

Remove CC prefix from code file name #1230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Jun 11, 2023
Merged

Remove CC prefix from code file name #1230

merged 11 commits into from
Jun 11, 2023

Conversation

@halx99
Copy link
Collaborator

@halx99 halx99 commented Jun 10, 2023 •
edited
Loading

THIS PROJECT IS IN DEVELOPMENT MODE. Any pull requests should merge to branch dev, otherwise will be rejected immediately.

Describe your changes

  • Remove CC prefix from code file name

Exists project mgirate guide

refer to: #1231

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code.
  • If it is a core feature, I have added thorough tests.
  • I have checked readme and add important infos to this PR (if it needed).
  • I have added/adapted some tests too.
@halx99 halx99 marked this pull request as ready for review June 11, 2023 04:18
@halx99 halx99 added this to the 1.0.0 milestone Jun 11, 2023
@halx99 halx99 added the enhancement New feature or request label Jun 11, 2023
@halx99 halx99 linked an issue Jun 11, 2023 that may be closed by this pull request
Migrate engine name, huge changes #724
Closed
11 tasks
@halx99 halx99 changed the title Bot migrate sources huge Remove CC prefix from code file name Jun 11, 2023
@halx99 halx99 merged commit 0c058a5 into dev Jun 11, 2023
@halx99 halx99 deleted the bot-migrate-sources-huge branch June 11, 2023 07:57
@rh101
Copy link
Contributor

rh101 commented Jun 11, 2023 •
edited
Loading

A few more files need updating, such as templates/cpp-template-default/proj.ios_mac/ios/RootViewController.mm, where it has this line:

#import "platform/ios/CCEAGLView-ios.h"
@halx99
Copy link
Collaborator Author

halx99 commented Jun 11, 2023

A few more files need updating, such as templates/cpp-template-default/proj.ios_mac/ios/RootViewController.mm, where it has this line:

#import "platform/ios/CCEAGLView-ios.h"

Thanks, will do later
@halx99
Copy link
Collaborator Author

halx99 commented Jun 11, 2023

Done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

3 participants

@halx99 @rh101