Adding support for namespaces #81
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Magizhchi approved these changes Aug 23, 2019
Contributor
Magizhchi left a comment
Magizhchi left a comment There was a problem hiding this comment.
Just a minor suggestion, LGTM to anyway.
| g.Expect(fetched).To(gomega.Equal(updated)) | ||
| | ||
| // Test Delete | ||
| g.Expect(c.Delete(context.TODO(), fetched)).NotTo(gomega.HaveOccurred()) |
Contributor
There was a problem hiding this comment.
NitPick: Would it be better to replace .NotTo(.HaveOccurred()) with .Should(Succeed()). IMO that would improve readability. I would leave either choice at your discretion.
Contributor Author
There was a problem hiding this comment.
I would keep same to match testing flow with other components we have for sake of uniformity.
| - update | ||
| - patch | ||
| - delete | ||
| - apiGroups: |
Contributor
There was a problem hiding this comment.
Just Curious, any idea why these roles are removed?
Contributor Author
There was a problem hiding this comment.
aws-eks-cluster-controller/config/rbac/rbac_role.yaml
Lines 7 to 26 in 97b9a5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change includes support for namespaces. It will allow aws-eks-cluster-controller to create namespaces in remote EKS cluster.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.