Added hardened boundary condition checks. #71
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
graebm reviewed Jan 5, 2022
bretambrose approved these changes Mar 17, 2022
| header.header_value_type = (enum aws_event_stream_header_value_type) * buffer; | ||
| buffer++; | ||
| aws_byte_cursor_read_u8(&buffer_cur, &header.header_name_len); | ||
| AWS_RETURN_ERROR_IF(header.header_name_len <= INT8_MAX, AWS_ERROR_EVENT_STREAM_MESSAGE_INVALID_HEADERS_LEN); |
There was a problem hiding this comment.
I stared at this macro name thinking "what the hell?" for about 5 minutes before looking up the definition and seeing the !
Unfortunate.
sertonix added a commit to sertonix/aws-c-event-stream that referenced this pull request Oct 10, 2025
Writing to the first byte of a multi-byte int value is inconsistent between endianess. Using a uint8_t value in between allows for correct results on big-endian systems as well. Fixes 53691ff Added hardened boundary condition checks. (awslabs#71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
added some assertions and error checking. Also removed some OOM handling since that's no longer possible.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.