Added more robust error handling around jar downloads #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
zengyu714 pushed a commit that referenced this pull request Dec 29, 2021
Bump jackson-dataformat-cbor from 2.12.4 to 2.13.0 (#6) Bump auth from 2.17.52 to 2.17.99 (#5) Bump sts from 2.17.52 to 2.17.99 (#3) Bump cloudwatch from 2.17.52 to 2.17.99 (#2) Bump slf4j-api from 1.7.30 to 1.7.32 (#9) Bump profiles from 2.17.52 to 2.17.99 (#8) Bump aws-cbor-protocol from 2.17.52 to 2.17.99 (#7) Bump dynamodb from 2.17.52 to 2.17.102 (#24) Bump aws-java-sdk-sts from 1.12.3 to 1.12.131 (#23) Bump aws-query-protocol from 2.17.52 to 2.17.102 (#22) Bump netty-transport from 4.1.68.Final to 4.1.72.Final (#27) Bump profiles from 2.17.52 to 2.17.102 (#26) Bump logback-core from 1.2.7 to 1.2.10 (#28) Signed-off-by: dependabot[bot] <support@github.com> Co-Authored-By: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I ran into an issue where our build was failing because amazon_kclpy/jars directory had been deleted. I've added better handling around the downloads from maven and testing for the directory before writing .jar's to disk.