Skip to content

Conversation

@seashman
Copy link
Contributor

@seashman seashman commented Mar 10, 2022

aws-doc-sdk-examples Pull Request

Thank you for making a submission to the aws-doc-sdk-examples repository. For more information about submitting pull requests to this repository, see Guidelines for contributing.

NOTE: This PR template contains three sections. Depending on the reason for your pull request, please fill out the section that applies to you and then remove the other two sections.

New SDK Code Example

The submitter has:

  • Added the default copyright notice to all files.
  • Created unit tests for all paths through the code and they all pass.
  • Run a linter against all code and implemented the resulting suggestions.
  • Added minimum usage documentation as comments in the code.
  • Had comments and strings reviewed and incorporated suggested changes.
  • Had the code reviewed and implemented the reviewer's suggested changes.

Existing Example Update

The submitter has:

  • Confirmed that the correct copyright is included in all files.
  • Major code changes have been reviewed, and the submitter has incorporated review comments.
  • Changed or added comments and strings have been reviewed, and the submitter has incorporated any and all suggested edits.

Resolve Issue

Issue #

Description of Changes

Add Amazon Personalize examples, tests, and README.md to JavaScript v3 example code.

  • I have tested my changes and created unit tests for new code paths.
  • Changes have been reviewed, and all reviewer comments have been incorporated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brmur brmur self-assigned this Mar 11, 2022
@brmur brmur added the High label Mar 11, 2022
@brmur brmur requested a review from lkdavies March 11, 2022 19:35
Copy link
Contributor

@lkdavies lkdavies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial comments

import { PutUsersCommand } from
"@aws-sdk/client-personalize-events";
import { personalizeEventsClient } from "./libs/personalizeClients.js";
// or create the client here
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or, create the client here.

// or create the client here
// const personalizeEventsClient = new PersonalizeEventsClient({ region: "REGION"});

// set the put users parameters. For string properties and values, use the \ character to escape quotes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize "Set"

// or create the client here
// const personalizeEventsClient = new PersonalizeEventsClient({ region: "REGION"});

// set the put users parameters. For string properties and values, use the \ character to escape quotes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize "Set"


Purpose:
putUsers.js demonstrates how to incrementally import a user into an Amazon Personalize dataset.
See https://docs.aws.amazon.com/personalize/latest/dg/API_UBS_PutUsers.html
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cd javascriptv3/example_code/personalize/src
npm install
```
3. In your text editor, update user variables specified in the ```Inputs``` section of the sample file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"update user variables" --> "update the user variables"

```
3. In your text editor, update user variables specified in the ```Inputs``` section of the sample file.

4. Run sample code:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Run the following sample code:
```

## Unit tests
For more information see, the [README](../README.rst).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"For more information see, the" --> "For more information, see the"

```

## Unit tests
For more information see, the [README](../README.rst).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"For more information see, the" --> "For more information, see the"

For more information see, the [README](../README.rst).

## Resources
- [AWS SDK for JavaScript v3 repo](https://github.com/aws/aws-sdk-js-v3)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

put v3 in parentheses: "AWS SDK for JavaScript (v3) repo"

Merge branch 'master' of github.com:seashman/aws-doc-sdk-examples
@brmur
Copy link
Contributor

brmur commented Jun 15, 2022

Recreated in #3247

@brmur brmur closed this Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants