Skip to content

Conversation

@brmur
Copy link
Contributor

@brmur brmur commented Dec 23, 2021

aws-doc-sdk-examples Pull Request

Thank you for making a submission to the aws-doc-sdk-examples repository. For more information about submitting pull requests to this repository, see Guidelines for contributing.

NOTE: This PR template contains three sections. Depending on the reason for your pull request, please fill out the section that applies to you and then remove the other two sections.

New SDK Code Example

The submitter has:

  • Added the default copyright notice to all files.
  • Created unit tests for all paths through the code and they all pass.
  • Run a linter against all code and implemented the resulting suggestions.
  • Added minimum usage documentation as comments in the code.
  • Had comments and strings reviewed and incorporated suggested changes.
  • Had the code reviewed and implemented the reviewer's suggested changes.

Existing Example Update

The submitter has:

  • Confirmed that the correct copyright is included in all files.
  • Major code changes have been reviewed, and the submitter has incorporated review comments.
  • Changed or added comments and strings have been reviewed, and the submitter has incorporated any and all suggested edits.

Resolve Issue

Issue #

Description of Changes

Please describe the changes you have made here.

  • I have tested my changes and created unit tests for new code paths.
  • Changes have been reviewed, and all reviewer comments have been incorporated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brmur brmur changed the title Add AWS SDK JS for V2 and V3 Lambda for Browser cross-service examples Add SoS for AWS SDK JS for V2 and V3 Lambda for Browser cross-service examples Dec 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants