Skip to content

Conversation

@Laren-AWS
Copy link
Contributor

@Laren-AWS Laren-AWS commented Nov 9, 2021

Python STS SOS data, snippet tags, and README update.

  • I have tested my changes and created unit tests for new code paths.
  • Changes have been reviewed, and all reviewer comments have been incorporated.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

sts_Scenario_SessionTokenMfa:
title: Get a session token that requires an MFA token with &STS; using an &AWS; SDK
title_abbrev: Get a session token that requires an MFA token
synopsis: get a session token that requires an MFA token with &STS; and use
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MFA -> multi-factor authentication (MFA)

(first use)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

sdkguide:
excerpts:
- description: Create an &IAM; user, register a mulfi-factor authentication
(MFA) device, and create a role that grants permission to let the user
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mulfi-factor authentication (MFA) -> MFA

(second use on page)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

- description: Destroy the resources created for the demo.
snippet_tags:
- python.example_code.sts.Scenario_AssumeRole_teardown
- description: Demonstrate how to use the previously defined functions.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'Demonstrate how to use the previously defined functions.' reads like the user can use this code to demonstrate how to use the previously defined functions. So maybe lead with an action verb - like 'Use/Run the previously defined functions.'? Just a suggestion.
(I know you've used this syntax in similar contexts in this PR (and in previously submitted PRs); so whatever you decide, make it consistent throughout.)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. I went with "Run this scenario by using the previously defined functions."

github: python/example_code/sts/sts_temporary_credentials
sdkguide:
excerpts:
- description: Create an &IAM; user, register a mulfi-factor authentication
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mulfi-factor -> multi-factor

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@Laren-AWS Laren-AWS merged commit d367f7b into awsdocs:main Nov 12, 2021
@Laren-AWS Laren-AWS deleted the Laren-AWS/sos-sts branch November 12, 2021 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants