Skip to content

Conversation

@irenepsmith
Copy link
Contributor

aws-doc-sdk-examples Pull Request

New SDK Code Example

The submitter has:

  • Added the default copyright notice to all files.
  • Run a linter against all code and implemented the resulting suggestions.
  • Added minimum usage documentation as comments in the code.
  • Had comments and strings reviewed and incorporated suggested changes.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

// SPDX-License-Identifier: Apache-2.0

/// <summary>
/// Add tags to an Amazon Glacier vault. This example was created using the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazon Simple Storage Service Glacier on first use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

// SPDX-License-Identifier: Apache-2.0

/// <summary>
/// This example creates an Amazon Glacier vault. It was created using the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazon Simple Storage Service Glacier on first use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

// SPDX-License-Identifier: Apache-2.0

/// <summary>
/// Retrieve and display information about an Amazon Glacier vault. It was
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazon Simple Storage Service Glacier on first use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

// SPDX-License-Identifier: Apache-2.0

/// <summary>
/// Download an Amazon Glacier archive using the high level API. This example
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazon Simple Storage Service Glacier on first use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

// SPDX-License-Identifier: Apache-2.0

/// <summary>
/// List the Amazon Glacier jobs for a vault. This example was created using
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazon Simple Storage Service Glacier on first use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed


var request = new ListTagsForVaultRequest
{
AccountId = "-",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as previous comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As before, this is correct, so I added a comment explaining why.

}
else
{
Console.WriteLine($"{vaultName} has not tags.");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no tags?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching that. Fixed.

// SPDX-License-Identifier: Apache-2.0

/// <summary>
/// Uses the Amazon Amazon Glacier Service to retrieve a list of the vaults
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazon Simple Storage Service Glacier on first use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

/// <summary>
/// Uses the Amazon Amazon Glacier Service to retrieve a list of the vaults
/// that belong to the default user. As it was written, it shows the vaults
/// that ar in the same aWS Regioin as the default user. If you want to show
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are in the same AWS Region

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

// SPDX-License-Identifier: Apache-2.0

/// <summary>
/// Upload a file to an Amazon Glacier vault. This example was created with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazon Simple Storage Service Glacier on first use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Doug-AWS Doug-AWS merged commit e62d820 into awsdocs:main Nov 1, 2021
@irenepsmith irenepsmith deleted the add-glacier-examples branch November 3, 2021 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants