Update Ruby Readmes for SoS #2225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Laren-AWS requested changes Oct 13, 2021
There was a problem hiding this comment.
I looked at the first couple of files and I see some overall issues I'd like addressed before I continue my review:
- Re-check service names against the service list (especially AWS vs. Amazon).
- Re-check links.
- Use current template format (standard headings and order of sections).
Laren-AWS requested changes Oct 14, 2021
ruby/example_code/cloudtrail/aws-ruby-sdk-cloudtrail-example-create-trail.rb Outdated Show resolved Hide resolved
ruby/example_code/cloudtrail/aws-ruby-sdk-cloudtrail-example-create-trail.rb Outdated Show resolved Hide resolved
ruby/example_code/sqs/sqs-ruby-example-redirect-queue-deadletters.rb Outdated Show resolved Hide resolved
Laren-AWS approved these changes Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.