Update JS SDK AWS CloudWatch metadata #2140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Laren-AWS requested changes Sep 25, 2021
Comment on lines 3 to 5
| title: Describing &CWL; subscription filters metrics using an &AWS; SDK | ||
| title_abbrev: Describe subscription filters metrics | ||
| synopsis: describe &CWLlong; subscription filters metrics. |
There was a problem hiding this comment.
The phrase "subscription filters metrics" reads weird to me. Maybe just "subscription filter"?
So things like: "Describe a subscription filter"
| cloudwatch-logs_PutSubscriptionFilter: | ||
| title: Creating a &CWL; subscription filter using an &AWS; SDK | ||
| title_abbrev: Create a subscription filter | ||
| synopsis: create an &CWlong; subscription filters metrics. |
There was a problem hiding this comment.
Just "subscription filter"?
| - cloudwatch-logs | ||
| cloudwatch-logs_DeleteSubscriptionFilters: | ||
| title: Deleting &CWL; subscription filters using an &AWS; SDK | ||
| title_abbrev: Delete subscription filters metrics |
There was a problem hiding this comment.
Just "Delete subscription filters"?
| cloudwatch-logs_PutSubscriptionFilter: | ||
| title: Creating a &CWL; subscription filter using an &AWS; SDK | ||
| title_abbrev: Create a subscription filter | ||
| synopsis: create an &CWlong; subscription filters metrics. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Update JS SDK AWS CloudWatch SoS metadata.