Skip to content

Conversation

@ghost
Copy link

@ghost ghost commented Aug 21, 2020

Checklist:

  • The submitter has added the default copyright notice to all files.

  • The submitter has added unit tests for all code paths, run all of them, and they all pass.

  • The submitter has run a linter on the code, and all of the submitter's team's minimum rules pass.

  • The submitter has added the team's minimum usage documentation to the code.

  • The submitter has had the code reviewed, and the submitter has incorporated any and all resulting review comments. (Not necessary for legacy code. The approach for this new code has already been approved by the development team.)

  • The submitter has had their Editor edit all comments and strings, and the submitter has incorporated any and all resulting edits.

  • The submitter has added all of the submitter's team's related API reporting metadata.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

…n item to a folder and to upload multiple items. Also fixed several minor reported RuboCop issues
@ghost ghost added on review labels Aug 21, 2020
…t test for uploading multiple items to an S3 bucket.
@ghost ghost assigned beckandros Aug 31, 2020
Copy link
Contributor

@beckandros beckandros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Edits for descriptions, comment strings.

@ghost ghost assigned brmur and unassigned beckandros Sep 2, 2020
@ghost ghost removed the on review label Sep 2, 2020
@brmur brmur merged commit 93149dc into master Sep 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants