DynamoDB examples cleanup #1241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
beckandros reviewed Jun 24, 2020
| @@ -0,0 +1,82 @@ | |||
| //Copyright 2010-2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
There was a problem hiding this comment.
Remove the date range for copyright--no longer required to use.
| @@ -0,0 +1,82 @@ | |||
| //Copyright 2010-2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | |||
| | |||
| /* ABOUT THIS NODE.JS EXAMPLE:This sample is part of the SDK for JavaScript Developer Guide topic at | |||
There was a problem hiding this comment.
(need a space following "EXAMPLE:" )
edit: ...This example is part...the AWS SDK for...
| //Copyright 2010-2019 Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| | ||
| /* ABOUT THIS NODE.JS EXAMPLE:This sample is part of the SDK for JavaScript Developer Guide topic at | ||
| // https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/dynamodb-example-query-scan.html |
There was a problem hiding this comment.
Need ending punctuation after URL.
| /* ABOUT THIS NODE.JS EXAMPLE:This sample is part of the SDK for JavaScript Developer Guide topic at | ||
| // https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/dynamodb-example-query-scan.html | ||
| Purpose: | ||
| ddb_batchwriteritem_tv.js populates the table used for the match query example https://docs.aws.amazon.com/sdk-for-javascript/v2/developer-guide/dynamodb-example-query-scan.html . |
There was a problem hiding this comment.
(remove the space between "html" and ending punctuation)
| // snippet-start:[dynamodb.JavaScript.v3.batch.BatchWriterItemTV] | ||
| // Import required AWS-SDK clients and commands for Node.js | ||
| const {DynamoDBClient, BatchWriteItemCommand } = require("@aws-sdk/client-dynamodb"); | ||
| // Set the AWS region |
| node ddb_query.js REGION | ||
| */ | ||
| // snippet-start:[dynamodb.JavaScript.v3.table.query] | ||
| // Import required AWS-SDK clients and commands for Node.js |
| // Import required AWS-SDK clients and commands for Node.js | ||
| const {DynamoDBClient, | ||
| QueryCommand} = require("@aws-sdk/client-dynamodb"); | ||
| // Set the AWS region |
| @@ -0,0 +1,34 @@ | |||
| --- | |||
| # Amazon Elastic Compute Cloud (ddb) basic usage examples | |||
There was a problem hiding this comment.
(ddb)? does this refer to DynamoDB, or is it the wrong acronym, should be Amazon EC2? If latter, then use the short name and no ddb:
Amazon EC2 basic usage examples
| @@ -1,49 +1,49 @@ | |||
| --- | |||
| # Amazon Elastic Compute Cloud (EC2) basic usage examples | |||
There was a problem hiding this comment.
Amazon EC2 basic usage examples
| @@ -1,43 +1,43 @@ | |||
| --- | |||
| # Amazon Simple Storage Service (S3) examples | |||
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Refactored and updated for V3 JS SDK.
Added Unit Tests
The submitter has added the default copyright notice to all files.
The submitter has added unit tests for all code paths, run all of them, and they all pass.
The submitter has run a linter on the code, and all of the submitter's team's minimum rules pass.
The submitter has added the team's minimum usage documentation to the code.
The submitter has had their Editor edit all comments and strings, and the submitter has incorporated any and all resulting edits.
The submitter has added all of the submitter's team's related API reporting metadata.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.