EC2 clean up and tests #1222
EC2 clean up and tests #1222
Conversation
| CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations under the License. | ||
| | ||
| ABOUT THIS NODE.JS SAMPLE: This sample is part of the SDK for JavaScript Developer Guide topic at |
There was a problem hiding this comment.
...NODE.JS EXAMPLE: This example is... of the AWS SDK...
(also add a period at end of sentence)
| CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations under the License. | ||
| | ||
| ABOUT THIS NODE.JS SAMPLE: This sample is part of the SDK for JavaScript Developer Guide topic at |
There was a problem hiding this comment.
...NODE.JS EXAMPLE: This example is... of the AWS SDK...
(also add a period at end of sentence)
| CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations under the License. | ||
| | ||
| ABOUT THIS NODE.JS SAMPLE: This sample is part of the SDK for JavaScript Developer Guide topic at |
There was a problem hiding this comment.
...NODE.JS EXAMPLE: This example is... of the AWS SDK...
(also add a period at end of sentence)
| CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations under the License. | ||
| | ||
| ABOUT THIS NODE.JS SAMPLE: This sample is part of the SDK for JavaScript Developer Guide topic at |
There was a problem hiding this comment.
...NODE.JS EXAMPLE: This example is... of the AWS SDK...
(also add a period at end of sentence)
| | ||
| Inputs: | ||
| - REGION (into command line below) | ||
| - MY_KEY_PAIR (in command line below) |
There was a problem hiding this comment.
...into command line below
| CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations under the License. | ||
| | ||
| ABOUT THIS NODE.JS SAMPLE: This sample is part of the SDK for JavaScript Developer Guide topic at |
There was a problem hiding this comment.
...NODE.JS EXAMPLE: This example is... of the AWS SDK...
(also add a period at end of sentence)
| CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations under the License. | ||
| | ||
| ABOUT THIS NODE.JS SAMPLE: This sample is part of the SDK for JavaScript Developer Guide topic at |
There was a problem hiding this comment.
...NODE.JS EXAMPLE: This example is... of the AWS SDK...
(also add a period at end of sentence)
| CONDITIONS OF ANY KIND, either express or implied. See the License for the | ||
| specific language governing permissions and limitations under the License. | ||
| | ||
| ABOUT THIS NODE.JS SAMPLE: This sample is part of the SDK for JavaScript Developer Guide topic at |
There was a problem hiding this comment.
...NODE.JS EXAMPLE: This example is... of the AWS SDK...
(also add a period at end of sentence)
| | ||
| Inputs: | ||
| - REGION (in command line input below) | ||
| - COMMAND (i.e. START or STOP) (in command line input below) |
There was a problem hiding this comment.
... (i.e.,...)
and could you combine these parens into one?
| | ||
| Inputs: | ||
| - REGION (in command line input below) | ||
| - STATE ('ON' or 'OFF') (in command line input below) |
There was a problem hiding this comment.
Can't combine these two parens into one?
ghost assigned 2 participants
Cleaned up S3 and EC2 Javascript examples examples.
Added unit tests.
Commented and documented.
The submitter has added the default copyright notice to all files.
The submitter has added unit tests for all code paths, run all of them, and they all pass.
The submitter has run a linter on the code, and all of the submitter's team's minimum rules pass.
The submitter has added the team's minimum usage documentation to the code.
The submitter has had their Editor edit all comments and strings, and the submitter has incorporated any and all resulting edits.
The submitter has added all of the submitter's team's related API reporting metadata.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.