Skip to content

Conversation

@XiaoxuanLu
Copy link
Contributor

Problem

If user has a package.json in the parent directory structure, then nodejs can load Flare with the incorrect module system

Solution

Add a dummy package to serve as the 'nearest parent package.json file' to force Node.js to treat Flare as CommonJS.

License

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@XiaoxuanLu XiaoxuanLu requested a review from a team as a code owner November 10, 2025 04:25
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 62.73%. Comparing base (9e08fe1) to head (2fe0c73).

Additional details and impacted files
@@ Coverage Diff @@ ## main #2472 +/- ## ========================================== + Coverage 62.71% 62.73% +0.01%  ========================================== Files 266 266 Lines 59697 59697 Branches 3840 3842 +2 ========================================== + Hits 37441 37451 +10  + Misses 22180 22170 -10  Partials 76 76 
Flag Coverage Δ
unittests 62.73% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@XiaoxuanLu XiaoxuanLu merged commit e72fef6 into main Nov 10, 2025
11 of 12 checks passed
@XiaoxuanLu XiaoxuanLu deleted the xiaoluk/dummy-package branch November 10, 2025 18:38
laileni-aws added a commit that referenced this pull request Nov 12, 2025
* feat(amazonq): send data to modifiedFilesTracker component as well * chore: update indexing bundle to 69c7a79c (#2460) * fix(amazon q): adding package-lock * chore(release): release packages from branch main (#2452) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Will Lo <96078566+Will-ShaoHua@users.noreply.github.com> * fix(amazonq): removed unnecessary LocalProjectContextController and LocalProjectContextServer changes * fix(amazonq): Still seeing the same error, reverting * chore: bump agentic version: 1.43.0 (#2463) Co-authored-by: aws-toolkit-automation <> * chore: add a dummy package in the server bundle (#2472) * chore: add the dummpy package back the the script * chore: fix the zip to cp * chore: move the file into zip folder * feat: differentiate implicit and explicit reject for inline completion (#2475) * feat: differenciate implicit and explicit reject for inline completion * fix: add UT for inline reject metric type * feat: ab test setup for new repomap strategy (#2474) Co-authored-by: Boyu <bywang@amazon.com> * chore: update indexing bundle to 4f4fd25d (#2478) * chore: patch d28867f PR #2474 (#2481) * chore: patch 940da04 PR #2478 (#2482) * fix: McpManager not initialized error (#2479) * fix: McpManager not initialized error * fix: adding more try catch to avoid crashes due to mcpmanager initialization error * fix: adding error to debug logs --------- Co-authored-by: Sherry Lu <75588211+XiaoxuanLu@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Will Lo <96078566+Will-ShaoHua@users.noreply.github.com> Co-authored-by: Boyu <bywang@amazon.com> Co-authored-by: Laxman Reddy <141967714+laileni-aws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants