refactor: Update AWS Glue Databrew StartJobRun step to use integration pattern input #176
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
Update AWS Glue Databrew service integration to use
integration_patterninput instead orwait_for_completionflag.Fixes #(issue) (N/A)
Why is the change necessary?
This change is necessary for consistency with the new service integration implementation pattern introduced in commit (Add support for Nested Step Functions) that uses the
integration_patternarg in the step constructor to build the resource.Support for AWS Glue Databrew service integration was added in this commit, but not released yet.
A later commit (Add support for Nested Step Functions) introduced a new implementation pattern using the
IntegrationPatternenum as input to construct the step instead of thewait_for_completionflag. (See PR for more detail on rationale behind the implementation).Solution
Replace the
wait_for_completionflag withintegration_patternarg in StartJobRun step construction.The
IntegrationPatternis used to build theResourcearn as follow:See Service Integration Patterns for more details
Normally, replacing a constructor argument would be a breaking change, but since we have not released support for AWS Glue Databrew service integration yet, it is acceptable to do so. After next release, it making such changes will be considered as not being backward compatible.
Testing
Manual Tests
Create a
Databrewjob for manual tests (<databrew_job_name>).For each test, create a workflow and execute as follow:
Pull Request Checklist
Please check all boxes (including N/A items)
Testing
Documentation
Title and description
Fixes #xxx- N/ABy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.