default behavior for configuration #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently the default behavior for specifying a connect requires region name. This should be the same as default constructor and attempt to retrieve it from the environment variables.
dchenbec reviewed Jan 11, 2021
Fixed Error message text and indentation
Error Message cleanup
fixed spacing
| Resolved indentation and exception text |
updated shaded jar excludes to include jackson libraries which are included in driver.
Merge update for branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When specifying the sigv4 authentication via the configuration file results in exception if the region name is not provided. This is a different default behavior than the programmatic instantiation. The following change will attempt to read the aws region from the environment variables/aws sdk configuration if no region is specified.
Description of changes:
passes null if region is not found in the configuration
new test using configuration
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.