Mark s3 client service definition as lazy #60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Instantiating a client has a big memory cost, because it loads a big JSON file (https://github.com/aws/aws-sdk-php/blob/master/src/data/s3/2006-03-01/api-2.json) Closes aws#59
pvgnd approved these changes Nov 7, 2019
jpeltier approved these changes Nov 7, 2019
holorhythms approved these changes Nov 7, 2019
| Oh wow thanks for the quick release! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Instantiating a client has a big memory cost, because it loads a big
JSON file (https://github.com/aws/aws-sdk-php/blob/master/src/data/s3/2006-03-01/api-2.json)
Closes #59
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.