Skip to content

Conversation

srchase
Copy link

@srchase srchase commented Jun 6, 2019

Resolves #51

Optional configuration validation and merging via AWS_MERGE_CONFIG env variable.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@srchase srchase requested a review from holorhythms June 6, 2019 22:01
Copy link
Contributor

@diehlaws diehlaws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

Copy link
Contributor

@holorhythms holorhythms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the configuration options be specified in a JSON file and then built programmatically, to make future updates simpler?

Copy link

@Oliboy50 Oliboy50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm waiting for this feature 👍

it's really counterintuitive to not have a bundle configuration merged, in the symfony ecosystem 😥

@holorhythms holorhythms merged commit 0a66b85 into aws:master Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants