Add the ability to mock BatchGet and MultiTableBatchGet operations #3407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ashovlin reviewed Aug 1, 2024
sdk/src/Services/DynamoDBv2/Custom/DataModel/IDynamoDBContext.cs Outdated Show resolved Hide resolved
normj requested changes Aug 1, 2024
normj approved these changes Aug 2, 2024
96malhar force-pushed the kmalhar/mock-batchget branch from 3ee0a50 to 17a433e Compare 96malhar force-pushed the feature/v4-ddb-mock branch from de93a95 to ad8c25d Compare normj approved these changes Aug 5, 2024
ashovlin approved these changes Aug 6, 2024
96malhar added a commit that referenced this pull request Aug 9, 2024
96malhar added a commit that referenced this pull request Aug 21, 2024
philasmar pushed a commit that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the ability to mock
BatchGetandMultiTableBatchGetoperations in DynamoDB.IDynamoDBContext.CreateBatchGet<T>(...)method now returns a genericIBatchGet<T>interfaceIDynamoDBContext.CreateMultiTableBatchGet(...)method now returns aIMultiTableBatchGetinterface.The
IBatchGet<T>interface also implements the non genericIBatchGetwhich defines theExecuteandExecuteAsyncmethod to carry out the BatchGet operations.I have added new unit tests to showcase how a user will mock these interfaces.
Motivation and Context
DOTNET-7676
Testing
Screenshots (if appropriate)
Types of changes
Checklist
License