Enable UrlConnection http client chunked encoding #4207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
millems reviewed Jul 19, 2023
| .build()) | ||
| .call(); | ||
| | ||
| mockServer.verify(postRequestedFor(urlPathEqualTo("/")).withHeader(TRANSFER_ENCODING, equalTo(CHUNKED))); |
There was a problem hiding this comment.
Can we verify the payload is correct?
There was a problem hiding this comment.
added check for payload contents
| SonarCloud Quality Gate failed.
|
millems approved these changes Jul 20, 2023
aws-sdk-java-automation added a commit that referenced this pull request Aug 13, 2025
…ce5083196 Pull request: release <- staging/03734786-26cb-4b35-9649-807ce5083196
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Enable chunked encoding in URLConnection HTTP Client.
setRequestProperty("Transfer-Encoding", "chunked")does not have any effectModifications
setChunkedStreamingMode(-1)whenTransfer-Encoding:chunkedis present, which will prompt HttpURLConnection to use the default chunklen value and enable chunked encodingTesting
To uncomment integ test from Apache fix PR once merged
Screenshots (if appropriate)
Types of changes
Checklist
mvn installsucceedsscripts/new-changescript and following the instructions. Commit the new file created by the script in.changes/next-releasewith your changes.License