Skip to content

Revert "feat: Support all formats of function name in invoke (#8295)" #8349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 15, 2025
Merged

Revert "feat: Support all formats of function name in invoke (#8295)" #8349

merged 1 commit into from
Oct 15, 2025

Conversation

@bnusunny
Copy link
Contributor

@bnusunny bnusunny commented Oct 15, 2025

This reverts commit 92e801e.

Mandatory Checklist

PRs will only be reviewed after checklist is complete

  • Add input/output type hints to new functions/methods
  • Write design document if needed (Do I need to write a design document?)
  • Write/update unit tests
  • Write/update integration tests
  • Write/update functional tests if needed
  • make pr passes
  • make update-reproducible-reqs if dependencies were changed
  • Write documentation

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
@bnusunny bnusunny requested a review from a team as a code owner October 15, 2025 18:31
@bnusunny bnusunny enabled auto-merge October 15, 2025 18:33
@bnusunny bnusunny added this pull request to the merge queue Oct 15, 2025
Merged via the queue into develop with commit 8c61192 Oct 15, 2025
80 of 82 checks passed
bchampp added a commit to bchampp/aws-sam-cli that referenced this pull request Oct 15, 2025
@bchampp
Reapply "feat: Support all formats of function name in invoke (aws#8295…
d8f7f4e 
…)" (aws#8349) This reverts commit 8c61192.
github-merge-queue bot pushed a commit that referenced this pull request Oct 22, 2025
@bchampp @seshubaws
feat: Support all formats of function name in invoke (#8351)
25639e0 
* Reapply "feat: Support all formats of function name in invoke (#8295)" (#8349) This reverts commit 8c61192. * fix: support nested stacks when normalizing function name * chore: add unit test to validate nested stacks work through local_lambda invoke --------- Co-authored-by: seshubaws <116689586+seshubaws@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/local/invoke sam local invoke command area/local/start-api sam local start-api command area/local/start-invoke pr/internal

3 participants

@bnusunny @vicheey @tobixlea