Skip to content

Conversation

@justsmth
Copy link
Contributor

Description of changes:

Bump aws-lc-sys to v0.35.0, align with AWS-LC v1.66.0.

Call-outs:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner December 15, 2025 16:28
@codecov-commenter
Copy link

codecov-commenter commented Dec 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.62%. Comparing base (c358484) to head (4026c00).
⚠️ Report is 298 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #972 +/- ## ========================================== - Coverage 95.80% 92.62% -3.18%  ========================================== Files 61 74 +13 Lines 8143 9982 +1839 Branches 0 9982 +9982 ========================================== + Hits 7801 9246 +1445  - Misses 342 452 +110  - Partials 0 284 +284 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@WillChilds-Klein
Copy link

rustls integration tests are still seeing the older patch version of aws-lc-rs. is that expected?

error: There are multiple `aws-lc-rs` packages in your project, and the specification `aws-lc-rs` is ambiguous. Please re-run this command with one of the following specifications: aws-lc-rs@1.15.1 aws-lc-rs@1.15.3 
@justsmth
Copy link
Contributor Author

justsmth commented Dec 15, 2025

rustls integration tests are still seeing the older patch version of aws-lc-rs. is that expected?

error: There are multiple `aws-lc-rs` packages in your project, and the specification `aws-lc-rs` is ambiguous. Please re-run this command with one of the following specifications: aws-lc-rs@1.15.1 aws-lc-rs@1.15.3 

Yeah, the way we do the integ testing for rustls is very fragile. I've been applying "bandaids" for awhile now, but it needs to be rewritten. There are better ways to do this. I'll add this refactoring to my TODO list.

@justsmth justsmth merged commit 2f0ee75 into aws:main Dec 16, 2025
339 of 346 checks passed
@justsmth justsmth deleted the generate/aws-lc-sys-v0.35.0 branch December 16, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants