Skip to content

Conversation

@justsmth
Copy link
Contributor

@justsmth justsmth commented Dec 2, 2025

Issues

Addresses:

Description of changes:

  • cc-builder: Move the setting of CFLAGS to before initialization of cc::Build.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.

@justsmth justsmth requested a review from a team as a code owner December 2, 2025 17:47
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.56%. Comparing base (c358484) to head (d4ad274).
⚠️ Report is 293 commits behind head on main.

Additional details and impacted files
@@ Coverage Diff @@ ## main #966 +/- ## ========================================== - Coverage 95.80% 92.56% -3.24%  ========================================== Files 61 74 +13 Lines 8143 9893 +1750 Branches 0 9893 +9893 ========================================== + Hits 7801 9157 +1356  - Misses 342 455 +113  - Partials 0 281 +281 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
@justsmth justsmth merged commit 0207364 into aws:main Dec 2, 2025
421 of 428 checks passed
@justsmth justsmth deleted the set-CFLAGS-before branch December 2, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants