Fix the use of a variable on range scope #238
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
As is, the code isn't wrong, but if concurrency is introduced in the tests, this gonna be a problem.
bmoffatt approved these changes Oct 9, 2019
Codecov Report
@@ Coverage Diff @@ ## master #238 +/- ## ======================================= Coverage 74.44% 74.44% ======================================= Files 20 20 Lines 677 677 ======================================= Hits 504 504 Misses 128 128 Partials 45 45Continue to review full report at Codecov.
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Description of changes:
Capture the variable during the loop to prevent concurrency problems.