Skip to content

Conversation

xiazhvera
Copy link
Contributor

@xiazhvera xiazhvera commented Sep 25, 2025

Issue #, if available:

Description of changes:

  1. Add CI job to validate required files
  2. Remove old samples

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@sbSteveK sbSteveK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears as though the entire main landing page Samples README.md was removed. Let's reinstate that. Everything else looks solid.

@@ -0,0 +1 @@
samples/mqtt/mqtt5_x509.py
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a short description to what this file is in case someone finds it here. It'd also be nice if we can add the cross-link to the AWS page/script/whatever that's accessing the listed file in case we expand this later to include things like greengrass etc...

Copy link
Contributor

@sbSteveK sbSteveK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix and ship

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants