New pypi wait strategy to fix release pipeline. #157
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This technique has been used in aws-crt-python (see PR awslabs/aws-crt-python#221) for weeks with great success. Use it here now too.
sdavtaker suggested changes Feb 22, 2021
justinboswell approved these changes Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
ISSUE:
The release pipeline would occasionally fail, due to the flakiness of our
wait-for-pypi.pyscript.SOLUTION:
Copy/paste the solution we've been using in aws-crt-python for the last few weeks without any problems. See the aws-crt-python PR here: awslabs/aws-crt-python#221
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.