Skip to content

Conversation

dawesc
Copy link

@dawesc dawesc commented Nov 21, 2024

The latest compilers require all C functions to have a prototype to compile; adds the void prototype to those functions requiring this

Issue #805

Description of changes:
Added void to the prototypes of methods requiring this to allow the application to build on latest versions of clang

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Check any applicable:

  • Were any files moved? Moving files changes their URL, which breaks all hyperlinks to the files.
@dawesc dawesc requested a review from a team as a code owner November 21, 2024 08:36
@dawesc dawesc had a problem deploying to continuous-integration November 21, 2024 16:48 — with GitHub Actions Failure
@dawesc dawesc had a problem deploying to continuous-integration November 21, 2024 16:49 — with GitHub Actions Error
@texastony
Copy link
Contributor

texastony commented Nov 21, 2024

Copying some CodeBuild test logs:
From build_test_dynamic:

43/43 Test #4: static_test_vectors ........................***Failed 204.96 sec Decryption successfully completed for 8208 test cases and failed for 1. 

I will kick off a retry for build_test_dynamic.

The other CodeBuild builds passed:

  • build_test_static_debug
  • build_test_static_valgrind
  • compliance

The retry of build_test_dynamic succeeded, but the GitHub webhook will not refresh the the batch status.

@texastony texastony changed the title fix: C standard requires prototype (#805) fix: C standard requires prototype Nov 21, 2024
The latest compilers require all C functions to have a prototype to compile, adds the void prototype to those functions requiring this
@dawesc
Copy link
Author

dawesc commented Nov 26, 2024

I've changed the comment to force a recompile to see if it will go through this time

@dawesc dawesc had a problem deploying to continuous-integration December 26, 2024 16:15 — with GitHub Actions Failure
@dawesc dawesc had a problem deploying to continuous-integration December 26, 2024 16:15 — with GitHub Actions Failure
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants