- Notifications
You must be signed in to change notification settings - Fork 991
standard:5.0 Golang version 1.18.1 support and bump to 1.16.15, 1.17.8 #519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| +1 |
| @clareliguori @leoherran-aws please 🙏😭 |
louie-pulse-id left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we all need this
| +1 |
mirpo left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
| temporary workaround for anyone stuck on this. add the following to your script: |
| @joekendal for some reason it didn't work for me: result: |
Can you confirm you have this error on aws/codebuild/standard:5.0 ? |
Exactly, this is breaking everyone's pipelines |
ubuntu/standard/5.0/Dockerfile Outdated
| RUN goenv install $GOLANG_15_VERSION; rm -rf /tmp/*; \ | ||
| goenv install $GOLANG_16_VERSION; rm -rf /tmp/*; \ | ||
| goenv install $GOLANG_17_VERSION; rm -rf /tmp/*; \ | ||
| goenv install $GOLANG_18_VERSION; rm -rf /tmp/*; \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why the change from && to ;? Are the goenv commands expected to fail?
Co-authored-by: Chris Rehn <crehn@outlook.com>
Co-authored-by: Lech Gajewski <60857116+lechgajewski@users.noreply.github.com>
| @lechgajewski sure! PR comment updated |
helmus left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would love to see support of 1.18.1 🙏
| again stuck? 🥇 |
| +1 |
| I am begging the maintainers of this repo to finally update the Go versions... |
| Please update the allowed Go versions as bitbucket has now twice broken our code pipelines due to problems with Golang versions. At least upgrade 1.16 to the latest version so we can use bitbucket repo's again. |
| Bitbucket just broke our pipelines again, please can we have an update for this PR? |
| Latest version of Go added in https://github.com/aws/aws-codebuild-docker-images/releases/tag/22.06.30 |
Closes Issues #518 and #478
Description of changes:
aws/codebuild/standard:5.0image changesgolang: 1.18.1golang: 1.15.15golang: 1.16.15golang: 1.17.8By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.