Exponential backoff for reconciler requests #822
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup and Fix
Which issue does this PR fix:
Fix
HandleReconcileErrorfunction to enable exponential backoff.Incase of transient errors from lattice apis keep static 10 seconds delay.
What does this PR do / Why do we need it:
According to the docs
RequeueResultif the returned error is non-nilRetryErrorbut since RetryError is just an alias for err type, all error types satisfy that if condition which leads to 20 second requeue delay for all errors. RefactoredNewRetryErrorfunction to returnRequeueNeededAftererror type instead.RetryErrwhich created err withLattice_Retryerror message withNewRetryErrorfunction call which returns a custom error type to fix type comparisons.If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
#462
Testing done on this change:
make
presubmitandmake e2e-testrun successfully.Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.