Non default ns #81
Merged
Non default ns #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
M00nF1sh reviewed Jan 31, 2023
| | ||
| if string(*httpBackendRef.Kind) == "ServiceImport" { | ||
| is_import = true | ||
| targetgroupNamespace = "default" |
There was a problem hiding this comment.
not related to this change:
should the default namespace be "default" or the HTTPRoute's namespace?
There was a problem hiding this comment.
Oh, this is to build the default rule for listener. It needs to pick one target group.
In this case, if 1st one is a service import, it needs to make sure the namespace is set
| /lgtm |
M00nF1sh approved these changes Jan 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue , if available:
#70
Description of changes:
Make sure populate namespace field when handling service import object
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.