Skip to content

Conversation

@rlymbur
Copy link
Contributor

@rlymbur rlymbur commented Feb 4, 2025

What type of PR is this?
Feature & Documentation

Which issue does this PR fix:
#701

What does this PR do / Why do we need it:
This reduces developer onboarding time and simplifies the setup process. It also includes upgrades to our tooling dependencies.

If an issue # is not available please add repro steps and logs from aws-gateway-controller showing the issue:
N/A

Testing done on this change:

make setup was ran successfully to setup a new cluster with make presubmit passing.

Automation added to e2e:

N/A

Will this PR introduce any new dependencies?:

No

Will this break upgrades or downgrades. Has updating a running cluster been tested?:
No

Does this PR introduce any user-facing change?:

`make setup` now replaces `make toolchain` to further automate the setup process 

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rlymbur rlymbur added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 4, 2025
@rlymbur rlymbur requested a review from mikestvz February 4, 2025 19:51
@rlymbur rlymbur enabled auto-merge (squash) February 4, 2025 19:51
Copy link
Contributor

@mikestvz mikestvz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rlymbur rlymbur merged commit 0089904 into aws:main Feb 5, 2025
2 checks passed
@rlymbur rlymbur deleted the 701 branch February 5, 2025 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

2 participants