Skip to content

Fix file rename in e2e test script and fix tag check in release script #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2024
Merged

Fix file rename in e2e test script and fix tag check in release script #634

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/e2e-test.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ jobs:
kubectl apply -f config/crds/bases/k8s-gateway-v1.0.0.yaml
- name: Create Lattice GatewayClass
run: |
kubectl apply -f examples/gatewayclass.yaml
kubectl apply -f files/controller-installation/gatewayclass.yaml
- name: Run test
run: |
make e2e-test
Expand Down
4 changes: 2 additions & 2 deletions scripts/github-release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,12 +43,12 @@ if git rev-parse --verify release-$RELEASE_VERSION >/dev/null 2>&1; then
git branch -D release-$RELEASE_VERSION
fi

if git ls-remote --tags origin | grep -q "refs/tags/$RELEASE_VERSION"; then
if git ls-remote --tags origin | grep -q "refs/tags/$RELEASE_VERSION$"; then
echo "Tag '$RELEASE_VERSION' exists in remote, you should manually delete it from github"
exit 1
fi

if git ls-remote --heads origin | grep -q "refs/heads/release-$RELEASE_VERSION"; then
if git ls-remote --heads origin | grep -q "refs/heads/release-$RELEASE_VERSION$"; then
echo "Branch 'release-$RELEASE_VERSION' exists in remote, you should manually delete it from github"
exit 1
fi
Expand Down