Skip creating serviceaccount #52
Conversation
helm/values.yaml Outdated
| serviceAccount: | ||
| # Specifies whether a service account should be created | ||
| create: true | ||
| create: false |
There was a problem hiding this comment.
I think this may break users installing for the first time, unless you're relying on eksctl (or something similar) to create the serviceaccount.
There was a problem hiding this comment.
Agree with @ellistarn here. The defaults should be set for new users.
There was a problem hiding this comment.
Today, the service account is always created by eksctl create iamserviceaccount first . step 3 in Readme and step3-step6 on Deploying the AWS API Controller. And they will run into error due to this if they follows the README or Deployment Guide
There was a problem hiding this comment.
My guess is that the vast majority of your users will not be using eksctl to manage their clusters. Better to flip this variable to false in the helm install for your getting started guide, but leave the helm default to true.
helm/values.yaml Outdated
| serviceAccount: | ||
| # Specifies whether a service account should be created | ||
| create: true | ||
| create: false |
There was a problem hiding this comment.
Agree with @ellistarn here. The defaults should be set for new users.
3 participants
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.