Skip to content

Fix boolean argument parsing #1681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aaronmarkham merged 1 commit into from
Nov 2, 2020
Merged

Fix boolean argument parsing #1681

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion hyperparameter_tuning/keras_bring_your_own/trainer/environment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,14 @@ def get(self, key, default=None, object_type=None):
"""
try:
value = self.hyperparameters_dict[key]
return object_type(value) if object_type else value
if not object_type:
return value
elif object_type == bool:
if value.lower() in ['True', 'true']:
return True
return False
else:
return object_type(value)
except KeyError:
return default

Expand Down