generated from amazon-archives/__template_Custom  
 -   Notifications  You must be signed in to change notification settings 
- Fork 138
v3.4.1 #247
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
   Merged  
     Merged  
 v3.4.1 #247
Changes from all commits
 Commits 
  File filter
Filter by extension
Conversations
 Failed to load comments.  
    Loading  
 Jump to
  Jump to file  
  Failed to load files.  
    Loading  
 Diff view
Diff view
There are no files selected for viewing
   This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
        This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
        This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
        This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
     | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.4.0 | ||
| 3.4.1 | 
   This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
     Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
  Oops, something went wrong.  
    This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
     Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
  Oops, something went wrong.  
    This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
     Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
  Oops, something went wrong.  
    This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
        This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
        56 changes: 56 additions & 0 deletions  56   source/infrastructure/lib/common-resources/common-cfn-parameters.ts          
     This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
     | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,56 @@ | ||
| // Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|  | ||
| import { CfnParameter } from "aws-cdk-lib"; | ||
| import { Construct } from "constructs"; | ||
|  | ||
| export interface CidBlockParameterProps { | ||
| default: string; | ||
| description: string; | ||
| constraintDescription: string; | ||
| } | ||
|  | ||
| export class CidrBlockCfnParameters extends Construct { | ||
| readonly vpcCidrBlock: CfnParameter; | ||
| readonly subnetACidrBlock: CfnParameter; | ||
| readonly subnetBCidrBlock: CfnParameter; | ||
|  | ||
| constructor(scope: Construct, id: string) { | ||
| super(scope, id); | ||
|  | ||
| const getCfnParameter = (scope: Construct, id: string, props: CidBlockParameterProps) => { | ||
| return new CfnParameter(scope, id, { | ||
| type: "String", | ||
| default: props.default, | ||
| description: props.description, | ||
| allowedPattern: "(^$|(\\d{1,3})\\.(\\d{1,3})\\.(\\d{1,3})\\.(\\d{1,3})/(\\d{1,2})$)", | ||
| constraintDescription: props.constraintDescription, | ||
| }); | ||
| }; | ||
|  | ||
| // VPC CIDR Block | ||
| this.vpcCidrBlock = getCfnParameter(this, "VpcCidrBlock", { | ||
| default: "192.168.0.0/16", | ||
| description: "You may leave this parameter blank if you are using existing VPC", | ||
| constraintDescription: "The VPC CIDR block must be a valid IP CIDR range of the form x.x.x.x/x.", | ||
| }); | ||
|  | ||
| // Subnet A CIDR Block | ||
| this.subnetACidrBlock = getCfnParameter(this, "SubnetACidrBlock", { | ||
| default: "192.168.0.0/20", | ||
| description: "CIDR block for subnet A of the AWS Fargate VPC", | ||
| constraintDescription: "The subnet CIDR block must be a valid IP CIDR range of the form x.x.x.x/x.", | ||
| }); | ||
|  | ||
| // Subnet B CIDR Block | ||
| this.subnetBCidrBlock = getCfnParameter(this, "SubnetBCidrBlock", { | ||
| default: "192.168.16.0/20", | ||
| constraintDescription: "The subnet CIDR block must be a valid IP CIDR range of the form x.x.x.x/x.", | ||
| description: "CIDR block for subnet B of the AWS Fargate VPC", | ||
| }); | ||
|  | ||
| this.vpcCidrBlock.overrideLogicalId("VpcCidrBlock"); | ||
| this.subnetACidrBlock.overrideLogicalId("SubnetACidrBlock"); | ||
| this.subnetBCidrBlock.overrideLogicalId("SubnetBCidrBlock"); | ||
| } | ||
| } | 
   This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
        This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters   
       Oops, something went wrong.  
  Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.    
 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When a future developer tries to update the version in the solution, they might search for 3.4.1, and they won't see that this line needs to change.