Skip to content

Conversation

@bogdankatishev
Copy link

Description of changes:
Added new CfnParameter: ExistingCognitoPoolId:

  • If empty string is passed (""): it will create a DLTUserPool Resource.
  • If an Cognito PoolId is passed: it will skip the creation of the DLTUserPool Resource and it will use your own given UserPool.

Also updated the snapshots and tests of the templates to includes these changes ⬆️

Checklist

  • 👋 I have run the unit tests, and all unit tests have passed.
  • ⚠️ This pull request might incur a breaking change.

A question towards the people of AWS/maintainers: should I include a Condition to skip the creation of the default admin user when giving an existing Cognito PoolId?

@dorrikh dorrikh requested a review from kamyarz-aws January 29, 2024 17:27
@kamyarz-aws
Copy link
Member

Thank you for this contribution. We will review this feature with our product team and if approved internally we will include this in one of our future releases with your name as a contributor.

@kamyarz-aws
Copy link
Member

Hi @bogdankatishev, can you please gives some more information on why do you want to include this feature. I understand the logic but I also want to know more how different users might use this feature.

@bogdankatishev
Copy link
Author

Hello @kamyarz-aws, I added this feature because we already had an existing Cognito UserPool within our AWS account where all the existing system accounts/etc... reside. And so we wanted to avoid creating a new UserPool, with only 1 default system user in it.

@bogdankatishev
Copy link
Author

Hello, any updates on this? @kamyarz-aws

@kamyarz-aws
Copy link
Member

kamyarz-aws commented Jan 15, 2025

We can reopen this when the item gets prioritized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants