Skip to content

Conversation

BastianZim
Copy link
Contributor

Issue #, if available: #634

Description of changes:

Adds THIRD-PARTY-LICENSES to the tarball.

Following #635, this adds (hopefully) the THIRD-PARTY-LICENSES to the tarball. Apparently, Poetry doesn't use Manifest anymore which is why it didn't work in the first try.

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@boring-cyborg boring-cyborg bot added the dependencies Pull requests that update a dependency file label Aug 22, 2021
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 22, 2021
@BastianZim
Copy link
Contributor Author

And sorry for the extra work, this is my first project with Poetry as a manager. 😄

@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2021

Codecov Report

Merging #641 (baa43bb) into develop (cdef9c4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## develop #641 +/- ## ======================================== Coverage 99.97% 99.97% ======================================== Files 116 116 Lines 4846 4846 Branches 265 265 ======================================== Hits 4845 4845 Partials 1 1 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdef9c4...baa43bb. Read the comment docs.

Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL too ;)

@heitorlessa heitorlessa merged commit c8cf3ba into aws-powertools:develop Aug 22, 2021
@BastianZim
Copy link
Contributor Author

😄 Let's hope it works this time.

Thanks for merging!

@BastianZim BastianZim deleted the patch-1 branch August 22, 2021 12:21
heitorlessa added a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Sep 28, 2021
…tools-python into develop * 'develop' of https://github.com/awslabs/aws-lambda-powertools-python: docs(event-handler): document catch-all routes (aws-powertools#705) chore: add python 3.9 support docs: add team behind it and email ISSUE-693: Use ExpressionAttributeNames in _put_record (aws-powertools#697) feat(validator): include missing data elements from a validation error (aws-powertools#686) chore(deps-dev): bump mkdocs-material from 7.2.8 to 7.3.0 (aws-powertools#695) chore(deps-dev): bump mkdocs-material from 7.2.6 to 7.2.8 (aws-powertools#682) chore(deps-dev): bump flake8-bugbear from 21.4.3 to 21.9.1 (aws-powertools#676) chore(deps): bump boto3 from 1.18.38 to 1.18.41 (aws-powertools#677) chore(deps-dev): bump radon from 4.5.2 to 5.1.0 (aws-powertools#673) chore(deps): bump boto3 from 1.18.32 to 1.18.38 (aws-powertools#671) refactor(data-classes): clean up internal logic for APIGatewayAuthorizerResponse (aws-powertools#643) fix(data-classes): use correct asdict funciton (aws-powertools#666) chore(deps-dev): bump xenon from 0.7.3 to 0.8.0 (aws-powertools#669) chore: bump to 1.20.2 fix: Fix issue with strip_prefixes (aws-powertools#647) chore(deps-dev): bump mkdocs-material from 7.2.4 to 7.2.6 (aws-powertools#665) chore(deps): bump boto3 from 1.18.26 to 1.18.32 (aws-powertools#663) chore(deps-dev): bump pytest from 6.2.4 to 6.2.5 (aws-powertools#662) chore(license): Add THIRD-PARTY-LICENSES (aws-powertools#641)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

3 participants