- Notifications
You must be signed in to change notification settings - Fork 460
feat(api-gateway): add support for custom serializer #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api-gateway): add support for custom serializer #568
Conversation
Codecov Report
@@ Coverage Diff @@ ## develop #568 +/- ## ======================================== Coverage 99.86% 99.86% ======================================== Files 113 113 Lines 4485 4489 +4 Branches 243 244 +1 ======================================== + Hits 4479 4483 +4 Misses 3 3 Partials 3 3
Continue to review full report at Codecov.
|
| @marcioemiranda @heitorlessa my initial PR is up |
| Thanks a lot Mike, including the illustrious XML example haha Q: Do we need a deserializer for event source data classes too? |
i should try it out :)
Like we did for idempotent utility? |
| Like we did for Logger: https://awslabs.github.io/aws-lambda-powertools-python/latest/core/logger/#bring-your-own-json-serializer It can be done in a separate PR. This PR already addresses the serialization ask, deserializing would be a sensible ask by anyone looking to understand why Note: AFAIK XML wouldn't work here because this feature requires API GW Proxy Resource. |
heitorlessa left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Syntactic sugar to ease maintenance later
Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
In the |
Yep. Any places where we'd deserialize, and one would want to have I'm merging this as is now, thanks a lot!!!!!! |
| Thanks a lot, this looks good. Any idea when this feature would be released? |
| If all goes well, this coming Friday (7th). I try releasing every two weeks, though this time there’s a major new utility - feature flags - which we are currently documenting it …On Sat, 31 Jul 2021 at 16:57, marcioemiranda ***@***.***> wrote: Thanks a lot, this looks good. Any idea when this feature would be released? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#568 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAZPQBAV6WE3GUSBJSAMSJLT2QFNFANCNFSM5BCTX2CA> . |
Issue #, if available:
Description of changes:
Add support a custom
serializerto allow for:Example usage:
Checklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.