Skip to content

feat(parser): add support for API Gateway HTTP API #434 #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 28, 2021
Merged

feat(parser): add support for API Gateway HTTP API #434 #441

merged 3 commits into from
May 28, 2021

Conversation

@ran-isenberg
Copy link
Contributor

@ran-isenberg ran-isenberg commented May 24, 2021

Support for API GW v2 proxy schema & envelope.
see issue #434
@codecov-commenter
Copy link

codecov-commenter commented May 24, 2021 •
edited
Loading

Codecov Report

Merging #441 (65eb3c8) into develop (578b01e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@ Coverage Diff @@ ## develop #441 +/- ## ======================================== Coverage 99.90% 99.90% ======================================== Files 102 104 +2 Lines 4124 4193 +69 Branches 205 205 ======================================== + Hits 4120 4189 +69  Misses 1 1 Partials 3 3
Impacted Files Coverage Δ
..._powertools/utilities/parser/envelopes/__init__.py 100.00% <100.00%> (ø)
...a_powertools/utilities/parser/envelopes/apigwv2.py 100.00% <100.00%> (ø)
...bda_powertools/utilities/parser/models/__init__.py 100.00% <100.00%> (ø)
...mbda_powertools/utilities/parser/models/apigwv2.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 578b01e...65eb3c8. Read the comment docs.
@ran-isenberg ran-isenberg mentioned this pull request May 24, 2021
Closed
@xpayn
Copy link

xpayn commented May 24, 2021 •
edited
Loading

Good job! :) Thanks
@heitorlessa heitorlessa added area/utilities feature New feature or functionality labels May 28, 2021
heitorlessa
heitorlessa suggested changes May 28, 2021
View reviewed changes
Copy link
Contributor

@heitorlessa heitorlessa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One tiny change that it seems to be a typo on a property that doesn't exist.
@heitorlessa heitorlessa self-assigned this May 28, 2021
@ran-isenberg @heitorlessa
Update aws_lambda_powertools/utilities/parser/models/apigwv2.py
7e01f2d 
 no idea how that got into there ;) Co-authored-by: Heitor Lessa <heitor.lessa@hotmail.com>
@heitorlessa
Copy link
Contributor

heitorlessa commented May 28, 2021

merging - thanks a lot @risenberg-cyberark ;)
@boring-cyborg boring-cyborg bot added the documentation Improvements or additions to documentation label May 28, 2021
@heitorlessa heitorlessa added this to the 1.17.0 milestone May 28, 2021
@heitorlessa heitorlessa changed the title feat: Add APIGateway*EventModelV2 to parser #434 feat(parser): add support for API Gateway HTTP API #434 May 28, 2021
@heitorlessa heitorlessa merged commit 995c56e into aws-powertools:develop May 28, 2021
@ran-isenberg ran-isenberg deleted the apigw2 branch June 7, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation feature New feature or functionality

4 participants

@ran-isenberg @codecov-commenter @xpayn @heitorlessa