refactor(parameters): improve typing for get_secret method #3910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pull-request-size bot added the size/M 
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@ ## develop #3910 +/- ## =========================================== - Coverage 96.38% 96.35% -0.03% =========================================== Files 214 214 Lines 10030 10126 +96 Branches 1846 1873 +27 =========================================== + Hits 9667 9757 +90 - Misses 259 265 +6 Partials 104 104 ☔ View full report in Codecov by Sentry. |
|
leandrodamascena approved these changes Mar 8, 2024
There was a problem hiding this comment.
Thanks for helping us improve the developer experience by adding these overloads and typing autocomplete in the IDE @TonySherman!
APPROVED!
leandrodamascena changed the title Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue number:
#3909
Summary
Changes
Adds overloads to
get_secret, very similar to #3534User experience
Type checkers should return the expected type based on the value in the transform argument.
If
None, return type should bestrIf
"json", return type should bedictIf
"binary", return type should bebytesIf
"auto", return type should bebytesChecklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.