Skip to content

fix(idempotency): validate before saving to cache #3822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 21, 2024
Merged

fix(idempotency): validate before saving to cache #3822

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d348280
fix(parameters): make cache aware of single vs multiple calls
heitorlessa Jul 25, 2023
e760bf2
chore: cleanup, add test for single and nested
heitorlessa Jul 25, 2023
8e0217c
refactor: validate before saving to cache
heitorlessa Feb 21, 2024
57f7f5e
fix: use multiprocess LIB to allow local functions by using dill over…
heitorlessa Feb 21, 2024
dcc7d60
chore: add test to prevent regression
heitorlessa Feb 21, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion aws_lambda_powertools/utilities/idempotency/persistence/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""
Persistence layers supporting idempotency
"""

import datetime
import hashlib
import json
Expand Down Expand Up @@ -383,9 +384,9 @@ def get_record(self, data: Dict[str, Any]) -> Optional[DataRecord]:

record = self._get_record(idempotency_key=idempotency_key)

self._validate_payload(data_payload=data, stored_data_record=record)
self._save_to_cache(data_record=record)

self._validate_payload(data_payload=data, stored_data_record=record)
return record

@abstractmethod
Expand Down
2 changes: 1 addition & 1 deletion aws_lambda_powertools/utilities/idempotency/persistence/dynamodb.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,10 +259,10 @@ def _put_record(self, data_record: DataRecord) -> None:
f"expiry_timestamp: {old_data_record.expiry_timestamp}, "
f"and in_progress_expiry_timestamp: {old_data_record.in_progress_expiry_timestamp}",
)
self._save_to_cache(data_record=old_data_record)

try:
self._validate_payload(data_payload=data_record, stored_data_record=old_data_record)
self._save_to_cache(data_record=old_data_record)
except IdempotencyValidationError as idempotency_validation_error:
raise idempotency_validation_error from exc

Expand Down