Skip to content
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor(parameters): Contistently reference env
Use the defined constants to look up service name environment varialbe NOTE: This does not default to `service_undefined`
  • Loading branch information
Michael Brewer committed Mar 8, 2021
commit a38c5751ccc65a0554ab32b97e350562d172abaf
4 changes: 3 additions & 1 deletion aws_lambda_powertools/utilities/parameters/appconfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
import boto3
from botocore.config import Config

from ...shared import constants
from .base import DEFAULT_PROVIDERS, BaseProvider

CLIENT_ID = str(uuid4())
Expand All @@ -33,6 +34,7 @@ class AppConfigProvider(BaseProvider):
**Retrieves the latest configuration value from App Config**

>>> from aws_lambda_powertools.utilities import parameters
>>>
>>> appconf_provider = parameters.AppConfigProvider(environment="my_env", application="my_app")
>>>
>>> value : bytes = appconf_provider.get("my_conf")
Expand Down Expand Up @@ -66,7 +68,7 @@ def __init__(

config = config or Config()
self.client = boto3.client("appconfig", config=config)
self.application = application or os.getenv("POWERTOOLS_SERVICE_NAME") or "application_undefined"
self.application = application or os.getenv(constants.SERVICE_NAME_ENV, "service_undefined")
self.environment = environment
self.current_version = ""

Expand Down