Skip to content

fix(core): import time latency by lazily loading high level modules #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 3, 2021
Merged

fix(core): import time latency by lazily loading high level modules #301

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
ac9957d
feat: initial working skeleton
heitorlessa Feb 28, 2021
f429a74
feat: use global lazy import for intellisense
heitorlessa Mar 1, 2021
2095142
fix: default lazy provider
heitorlessa Mar 1, 2021
e85aaf8
chore: trigger CI #1
heitorlessa Mar 1, 2021
188a517
chore: trigger CI #2
heitorlessa Mar 1, 2021
cc2e0a5
chore: uncaught linting
heitorlessa Mar 1, 2021
90dab81
feat: add minimum generic interface for Tracing Provider and Segment
heitorlessa Mar 1, 2021
988c647
fix: type hints
heitorlessa Mar 2, 2021
8b6e1e8
refactor: use JSON Schema as dict to reduce I/O latency
heitorlessa Mar 2, 2021
ec76841
docs: changelog
heitorlessa Mar 2, 2021
79fa14d
test: add perf tests for import
heitorlessa Mar 2, 2021
28c12ee
test: adjust perf bar to flaky/CI machines
heitorlessa Mar 2, 2021
33518ba
fix(pytest): enforce coverage upon request only
heitorlessa Mar 2, 2021
538af2a
chore: address PR's review
heitorlessa Mar 3, 2021
c586b3c
chore: correctly redistribute apache 2.0 unmodified code
heitorlessa Mar 3, 2021
01445a3
chore: test labeler
heitorlessa Mar 3, 2021
50c89e9
refactor: lazy load fastjsonschema to prevent unnecessary http.client…
heitorlessa Mar 3, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: default lazy provider
  • Loading branch information
@heitorlessa
heitorlessa committed Mar 1, 2021
commit 2095142eaffd329bcc5d9e2a4e06b15250d58f52
4 changes: 2 additions & 2 deletions aws_lambda_powertools/tracing/tracer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -685,7 +685,7 @@ def _add_full_exception_as_metadata(
def _disable_tracer_provider():
"""Forcefully disables tracing"""
logger.debug("Disabling tracer provider...")
aws_xray_sdk.global_sdk_config.set_sdk_enabled(False)
aws_xray_sdk.global_sdk_config.set_sdk_enabled(False) # noqa: F821

@staticmethod
def _is_tracer_disabled() -> bool:
Expand Down Expand Up @@ -729,7 +729,7 @@ def __build_config(
is_disabled = disabled if disabled is not None else self._is_tracer_disabled()
is_service = service if service is not None else os.getenv(constants.SERVICE_NAME_ENV)

self._config["provider"] = provider if provider is not None else self._config["provider"]
self._config["provider"] = provider or self._config["provider"] or aws_xray_sdk.core.xray_recorder
self._config["auto_patch"] = auto_patch if auto_patch is not None else self._config["auto_patch"]
self._config["service"] = is_service or self._config["service"]
self._config["disabled"] = is_disabled or self._config["disabled"]
Expand Down