fix(metrics): proxy service and namespace attrs to provider #2910
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
pull-request-size bot added the size/M 
| Kudos, SonarCloud Quality Gate passed!
|
heitorlessa changed the title 
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@ ## develop #2910 +/- ## =========================================== - Coverage 96.43% 96.41% -0.03% =========================================== Files 169 169 Lines 7666 7678 +12 Branches 1447 1451 +4 =========================================== + Hits 7393 7403 +10 - Misses 217 219 +2 Partials 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
heitorlessa changed the title 
heitorlessa approved these changes Aug 2, 2023
heitorlessa added a commit to heitorlessa/aws-lambda-powertools-python that referenced this pull request Aug 2, 2023
* develop: chore: cleanup, add test for single and nested fix(parameters): make cache aware of single vs multiple calls fix(metrics): proxy service and namespace attrs to provider (aws-powertools#2910) chore(deps-dev): bump ruff from 0.0.281 to 0.0.282 (aws-powertools#2905)
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue number: #2909
Summary
Changes
This PR introduces getter/setter methods.
User experience
Checklist
If your change doesn't seem to apply, please leave them unchecked.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.