fix: accessing boolean value in dynamodb utility class #176
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…namodb. It seems that when accessing boolean value from dynamodb index name `bool` is used instead of correct one `BOOL`. Have a look at https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_AttributeValue.html to see list of available attribute values
whisller changed the title bool to BOOL index name when accessing boolean value in dy…
Codecov Report
@@ Coverage Diff @@ ## develop #176 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 52 52 Lines 2154 2154 Branches 97 97 ========================================= Hits 2154 2154
Continue to review full report at Codecov.
|
| Thank you for that quick fix @whisller - merging, and I'll release a patch version tomorrow morning (CEST time), in case there's anything else we missed |
| @heitorlessa no worries! Thank you for quick reply! |
| @whisller - awesome! Thank for fixing that |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
It seems that when accessing boolean value from dynamodb index name
boolis used instead of correct oneBOOL.Have a look at https://docs.aws.amazon.com/amazondynamodb/latest/APIReference/API_AttributeValue.html to see list of available attribute values
Issue #, if available:
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.