Skip to content

feat(event_handler): add cookies as 1st class citizen in v2 #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Sep 2, 2022
Merged

feat(event_handler): add cookies as 1st class citizen in v2 #1487

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
0e3a17c
feat(event_handler): improved support for headers and cookies in v2 (…
rubenfonseca Aug 29, 2022
18599da
feat(event_handler): add Cookies first class citizen
rubenfonseca Aug 31, 2022
9ce3d8d
chore(event_handler): move cookies to shared (cicular dependency)
rubenfonseca Sep 1, 2022
291c970
chore(cookies): format date
rubenfonseca Sep 1, 2022
b1921e4
chore(event_handler): renamed method
rubenfonseca Sep 1, 2022
bd6c1a2
chore(tests): add e2e tests for the new cookies
rubenfonseca Sep 2, 2022
fe4ea7d
chore(docs): updated docs
rubenfonseca Sep 2, 2022
73dce34
chore: add sample timestamp for cookie RFC
heitorlessa Sep 2, 2022
788aa55
docs: secure attr is the default now
heitorlessa Sep 2, 2022
a1e9e75
chore(event_handler): fix order of parameters
rubenfonseca Sep 2, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(event_handler): renamed method
  • Loading branch information
@rubenfonseca
rubenfonseca committed Sep 2, 2022
commit b1921e4ae6de4474194c9035b281e74244235e3d
4 changes: 2 additions & 2 deletions aws_lambda_powertools/shared/cookies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ class SameSite(Enum):
NONE_MODE = "None"


def _getdate(timestamp: datetime) -> str:
def _format_date(timestamp: datetime) -> str:
return timestamp.strftime("%a, %d %b %Y %H:%M:%S GMT")


Expand Down Expand Up @@ -51,7 +51,7 @@ def __str__(self) -> str:
payload.write(f"; Domain={self.domain}")

if self.expires:
payload.write(f"; Expires={_getdate(self.expires)}")
payload.write(f"; Expires={_format_date(self.expires)}")

if self.max_age:
if self.max_age > 0:
Expand Down