Skip to content

docs(examples): enforce and fix all mypy errors #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Jul 28, 2022
Merged

docs(examples): enforce and fix all mypy errors #1393

Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
53ad2ed
chore(mypy): fix redef _
heitorlessa Jul 28, 2022
ab10966
fix(tracer): correct ctx manager and default provider type
heitorlessa Jul 28, 2022
c55a9c1
chore(mypy): add requests type def as dev dep
heitorlessa Jul 28, 2022
3ba9e8a
chore(mypy): ignore lack of botocore types
heitorlessa Jul 28, 2022
f905451
chore(mypy): ignore lack of orjson types
heitorlessa Jul 28, 2022
6c24df6
chore(example): fix constructor default
heitorlessa Jul 28, 2022
23b5179
chore(mypy): ignore sentinel value assignment; needs issue
heitorlessa Jul 28, 2022
91ead7f
docs(examples): fix incorrect type response and Response class
heitorlessa Jul 28, 2022
15b6351
chore(mypy): fix potential none operator
heitorlessa Jul 28, 2022
ff5ec56
chore(mypy): fix return type on graphql merchant
heitorlessa Jul 28, 2022
6718279
chore(mypy): fix missing return
heitorlessa Jul 28, 2022
3ae1575
chore(mypy): ignore sentinel type, missing return
heitorlessa Jul 28, 2022
fe713c3
chore(mypy): ignore present attr defined in custom model; note for te…
heitorlessa Jul 28, 2022
306bfd3
chore(mypy): fix import and type annotation on async graphql
heitorlessa Jul 28, 2022
f1d1ff3
chore(mypy): fix coroutine response not being ready to subscribe
heitorlessa Jul 28, 2022
a9e7ca5
chore(ci): ensure mypy runs on examples
heitorlessa Jul 28, 2022
3135117
chore(mypy): address leftovers
heitorlessa Jul 28, 2022
bb583f4
chore(mypy): use backward compatible List annotation
heitorlessa Jul 28, 2022
cf29df7
chore(mypy): use backward compatible List annotation
heitorlessa Jul 28, 2022
d0ede58
Merge branch 'docs/examples-mypy' of https://github.com/heitorlessa/a…
heitorlessa Jul 28, 2022
cb791a4
chore(mypy): add typing_extensions, 3.6 3.7 compatible changes
heitorlessa Jul 28, 2022
1cbf580
docs(examples): fix highlighting due to backwards compatible typedict…
heitorlessa Jul 28, 2022
5004034
chore: leftover from rebase
heitorlessa Jul 28, 2022
0fd0820
Merge branch 'develop' of https://github.com/awslabs/aws-lambda-power…
heitorlessa Jul 28, 2022
d3d196e
chore(mypy): add leftover assignment ignore
heitorlessa Jul 28, 2022
4a98d0e
Revert "chore(mypy): add leftover assignment ignore"
heitorlessa Jul 28, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore(mypy): fix coroutine response not being ready to subscribe
  • Loading branch information
@heitorlessa
heitorlessa committed Jul 28, 2022
commit f1d1ff3113cd24bf92b6707d035fa0087e9c44f9
4 changes: 2 additions & 2 deletions examples/event_handler_graphql/src/assert_async_graphql_response_module.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,8 @@ class Todo(TypedDict, total=False):
async def list_todos() -> list[Todo]:
async with aiohttp.ClientSession(trace_configs=[aiohttp_trace_config()]) as session:
async with session.get("https://jsonplaceholder.typicode.com/todos") as resp:
# first two results to demo assertion
return await resp.json()[:2]
result: list[Todo] = await resp.json()
return result[:2] # first two results to demo assertion


@logger.inject_lambda_context(correlation_id_path=correlation_paths.APPSYNC_RESOLVER)
Expand Down