Skip to content

Conversation

heitorlessa
Copy link
Contributor

@heitorlessa heitorlessa commented Aug 15, 2020

Issue #, if available: #108

Description of changes:

Clarifies auto_patch=False feature when reusing Tracer across multiple modules, or in Lambda Layers, where import order creates a side effect where no modules end up being patched.

image

Checklist

Breaking change checklist

RFC issue #:

  • Migration process documented
  • Implement warnings (if it can live side by side)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@heitorlessa heitorlessa added the documentation Improvements or additions to documentation label Aug 15, 2020
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2020

Codecov Report

Merging #109 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@ ## develop #109 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 17 17 Lines 499 499 Branches 46 46 ========================================= Hits 499 499 

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 24a3bdf...c6cf2af. Read the comment docs.

Copy link
Contributor

@michaelbrewer michaelbrewer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks this clarifies it well!

@heitorlessa heitorlessa changed the title docs: clarify auto_patch as per #108 docs: clarify Tracer auto_patch as per #108 Aug 16, 2020
@heitorlessa heitorlessa merged commit 32549c8 into aws-powertools:develop Aug 16, 2020
@heitorlessa heitorlessa deleted the docs/tracer-reuse branch August 16, 2020 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

3 participants