- Notifications
You must be signed in to change notification settings - Fork 458
feat(event_handler): support multiple origins for cors #1010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| The PR allows for multiple statically defined Origins. Some use cases may have more dynamic requirements, e.g. An API allowing only subscribed websites (origins) to consume the API from their front-end. This may be a more obscure use case and not the norm though - so need to apply the tenets to this comment as appropriate. |
Codecov Report
@@ Coverage Diff @@ ## develop #1010 +/- ## ======================================== Coverage 99.88% 99.88% ======================================== Files 119 119 Lines 5423 5432 +9 Branches 618 620 +2 ======================================== + Hits 5417 5426 +9 Misses 2 2 Partials 4 4
Continue to review full report at Codecov.
|
This is where people might shoot themselves in the foot ? :) |
| Agree. Need to temper feature offered to close the loop on people doing silly things. Because CORS is generally well misunderstood 🙂 |
And universally hated |
| (closing for now and will reopening when capacity is available for this) |
| I would relly love to see this getting merged soon. The Lambda function is called from multiple origins, but it's a fixed list, so no dynamic matching needed. |
| @major-mayer - possibly August this might get some eyes. |
Issue #, if available:
Description of changes:
Checklist
Breaking change checklist
RFC issue #:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.