- Notifications
You must be signed in to change notification settings - Fork 33
chore: update docs #864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update docs #864
Conversation
…s-lambda-dotnet into chore/update-docs # Conflicts: # mkdocs.yml
Includes #855 |
…s-lambda-dotnet into chore/update-docs
…/powertools-lambda-dotnet into chore/update-docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @hjgraca! I left some comments.
--- | ||
| ||
!!! warning | ||
Version 1.x.x will continue to be supported until **end of July 2025** for critical bug fixes and security updates in very exceptional cases where you cannot update to v2, but no new features will be added to this version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Our versioniong policy says that we must support versions for at least 6 months. Is that a reasonable time frame? I don't know exactly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For this specific case we want to move fast to v2, since there are no major (none almost) breaking changes, the support can be 3 months. and releases to v1 will be very few if not none
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure I agree with this. I'd rather stick with our versionining policy and keep it for 6 months, especially since we're giving the customer a delayed response since v2 was released and customers will have roughly 1 month to migrate.
What is the impact to keep it for 6 months? Can we keep the pipelines and fix any security issue and stuff?
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was decided in another discussion, but I have no issues with keeping 6 months, there is no difference 6 months or 3 months on our side. The main argument is that since there are no breaking changes all users should move to v2. But again no problem with changing, I will update
Co-authored-by: Leandro Damascena <leandro.damascena@gmail.com> Signed-off-by: Henrique Graca <999396+hjgraca@users.noreply.github.com>
Signed-off-by: Henrique Graca <999396+hjgraca@users.noreply.github.com>
|
Issue number: #863
Summary
Changes
User experience
Checklist
Please leave checklist items unchecked if they do not apply to your change.
Is this a breaking change?
RFC issue number:
Checklist:
Acknowledgment
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.