Skip to content

Conversation

hjgraca
Copy link
Contributor

@hjgraca hjgraca commented Apr 29, 2025

Please provide the issue number

Issue number: #863

Summary

Changes

image

image

image

image

image

User experience

Please share what the user experience looks like before and after this change

Checklist

Please leave checklist items unchecked if they do not apply to your change.

Is this a breaking change?

RFC issue number:

Checklist:

  • Migration process documented
  • Implement warnings (if it can live side by side)

Acknowledgment

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added documentation Improvements or additions to documentation github-actions Changes in GitHub workflows internal Maintenance changes labels Apr 29, 2025
@pull-request-size pull-request-size bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Apr 29, 2025
@hjgraca
Copy link
Contributor Author

hjgraca commented May 5, 2025

Includes #855

@hjgraca hjgraca requested a review from leandrodamascena May 6, 2025 10:03
Copy link
Contributor

@leandrodamascena leandrodamascena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @hjgraca! I left some comments.

---

!!! warning
Version 1.x.x will continue to be supported until **end of July 2025** for critical bug fixes and security updates in very exceptional cases where you cannot update to v2, but no new features will be added to this version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our versioniong policy says that we must support versions for at least 6 months. Is that a reasonable time frame? I don't know exactly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this specific case we want to move fast to v2, since there are no major (none almost) breaking changes, the support can be 3 months. and releases to v1 will be very few if not none

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure I agree with this. I'd rather stick with our versionining policy and keep it for 6 months, especially since we're giving the customer a delayed response since v2 was released and customers will have roughly 1 month to migrate.
What is the impact to keep it for 6 months? Can we keep the pipelines and fix any security issue and stuff?

WDYT?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was decided in another discussion, but I have no issues with keeping 6 months, there is no difference 6 months or 3 months on our side. The main argument is that since there are no breaking changes all users should move to v2. But again no problem with changing, I will update

hjgraca and others added 2 commits May 6, 2025 11:37
Co-authored-by: Leandro Damascena <leandro.damascena@gmail.com> Signed-off-by: Henrique Graca <999396+hjgraca@users.noreply.github.com>
Signed-off-by: Henrique Graca <999396+hjgraca@users.noreply.github.com>
@hjgraca hjgraca requested a review from leandrodamascena May 6, 2025 10:42
@hjgraca hjgraca merged commit b015816 into develop May 6, 2025
5 checks passed
@hjgraca hjgraca deleted the chore/update-docs branch May 6, 2025 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation github-actions Changes in GitHub workflows internal Maintenance changes size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
2 participants